libstore/http-binary-cache-store: Improve error messages in HttpBinar…#14406
Merged
libstore/http-binary-cache-store: Improve error messages in HttpBinar…#14406
Conversation
…yCacheStore::upsertFile
Now the error message doesn't cram everything into a single line and we now instead get:
error:
… while uploading to HTTP binary cache at 's3://my-cache?endpoint=http://localhost:9000?compression%3Dzstd®ion=eu-west-1'
error: unable to download 'http://localhost:9000/my-cache/nar/1125zqba8cx8wbfa632vy458a3j3xja0qpcqafsfdildyl9dqa7x.nar.xz': Operation was aborted by an application callback (42)
github-actions
bot
added
the
store
xokdvium
commented
Oct 28, 2025
| getFileTransfer()->upload(req); | ||
| } catch (FileTransferError & e) { | ||
| throw UploadToHTTP("while uploading to HTTP binary cache at '%s': %s", config->cacheUri.to_string(), e.msg()); | ||
| UploadToHTTP err(e.message()); |
Contributor
Author
There was a problem hiding this comment.
Note the .message() here. It's to ensure that we don't get the error: prefix twice.
lovesegfault
approved these changes
Oct 28, 2025
Ericson2314
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…yCacheStore::upsertFile
Motivation
Now the error message doesn't cram everything into a single line and we now instead get:
Context
Noticed while doing #14390.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.